Re: [PATCH v5 00/18] net/ixgbe: Consistent filter API
From: Ferruh Yigit <hidden>
Date: 2017-01-12 15:43:29
From: Ferruh Yigit <hidden>
Date: 2017-01-12 15:43:29
Hi Wei, On 1/12/2017 9:17 AM, Wei Zhao wrote:
The patches mainly finish following functions: 1) Store and restore all kinds of filters. 2) Parse all kinds of filters. 3) Add flow validate function. 4) Add flow create function. 5) Add flow destroy function. 6) Add flow flush function.
Overall patchset looks good, only major comment is adding more comments on parse_filter functions for expected/valid rules. You can keep Beilei's Ack for next version of the patchset. Thanks, ferruh