Thread (148 messages) 148 messages, 7 authors, 2017-01-25

Re: [PATCH v2 10/18] net/ixgbe: flush all the filters

From: Zhao1, Wei <hidden>
Date: 2017-01-11 07:51:39

Hi,yigit
-----Original Message-----
From: Yigit, Ferruh
Sent: Saturday, January 7, 2017 12:40 AM
To: Zhao1, Wei <redacted>; dev@dpdk.org
Cc: Lu, Wenzhuo <redacted>
Subject: Re: [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters

On 12/30/2016 7:53 AM, Wei Zhao wrote:
quoted
Add support for flush all the filters in SW.

Signed-off-by: Wenzhuo Lu <redacted>
Signed-off-by: Wei Zhao <redacted>

---

v2:
--change flush filter function call relationship
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 118
++++++++++++++++++++++++++++++++++++++-
quoted
 drivers/net/ixgbe/ixgbe_ethdev.h |   9 +++
 drivers/net/ixgbe/ixgbe_fdir.c   |  24 ++++++++
 drivers/net/ixgbe/ixgbe_pf.c     |   1 +
 4 files changed, 150 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
b/drivers/net/ixgbe/ixgbe_ethdev.c
index d68de65..0de1318 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -61,6 +61,8 @@
 #include <rte_random.h>
 #include <rte_dev.h>
 #include <rte_hash_crc.h>
+#include <rte_flow.h>
+#include <rte_flow_driver.h>

 #include "ixgbe_logs.h"
 #include "base/ixgbe_api.h"
@@ -386,7 +388,8 @@ static int ixgbe_dev_udp_tunnel_port_del(struct
rte_eth_dev *dev,
quoted
 					 struct rte_eth_udp_tunnel
*udp_tunnel);  static int
quoted
ixgbe_filter_restore(struct rte_eth_dev *dev);  static void
ixgbe_l2_tunnel_conf(struct rte_eth_dev *dev);
-
+static int ixgbe_flow_flush(struct rte_eth_dev *dev,
+		struct rte_flow_error *error);
I think it is good idea to move all rte_flow related code into a new file, as
done in i40e (i40e_flow.c)? What do you think, can it be done?
I will do  as your suggestion in v3.
<...>
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help