Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction
From: Shreyansh Jain <hidden>
Date: 2017-01-18 10:53:42
-----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] Sent: Wednesday, January 18, 2017 4:16 PM To: Shreyansh Jain <redacted> Cc: dev@dpdk.org Subject: Re: [PATCH v9 01/12] eal/bus: introduce bus abstraction 2017-01-18 16:07, Shreyansh Jain:quoted
+void +rte_bus_register(struct rte_bus *bus) +{ + RTE_VERIFY(bus); + RTE_VERIFY(bus->name && strlen(bus->name)); + + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); + RTE_LOG(DEBUG, EAL, "Registered [%s] bus.\n", bus->name); +} + +void +rte_bus_unregister(struct rte_bus *bus) +{ + TAILQ_REMOVE(&rte_bus_list, bus, next); + RTE_LOG(INFO, EAL, "Unregistered [%s] bus.\n", bus->name); +}This log should be DEBUG, consistently with "register" one.
:( Obvious miss. I will change it.
quoted
+DPDK_17.02 { + global: + + rte_bus_list;So finally, is it an useful symbol? Could it be removed from this patch?
It is required until test_bus is re-written. I can move this to next patch (which introduces test_bus).