Thread (146 messages) 146 messages, 7 authors, 2017-04-14

Re: [PATCH v8 1/9] eal/bus: introduce bus abstraction

From: Thomas Monjalon <hidden>
Date: 2017-01-17 23:19:51

2017-01-17 19:07, Shreyansh Jain:
+void
+rte_bus_register(struct rte_bus *bus)
+{
+	RTE_VERIFY(bus);
+	RTE_VERIFY(bus->name && strlen(bus->name));
+
+	TAILQ_INSERT_TAIL(&rte_bus_list, bus, next);
+	RTE_LOG(INFO, EAL, "Registered [%s] bus.\n", bus->name);
I think it should be a debug log.
+/* unregister a bus */
+void
+rte_bus_unregister(struct rte_bus *bus)
I appreciate the effort for commenting, but I think the function name
is self describing.
+/**
+ * @file
+ *
+ * RTE PMD Bus Abstraction interfaces
RTE PMD?
I would say "DPDK device bus interface"
+DPDK_17.02 {
+	global:
+
+	rte_bus_list;
Why the bus list is exported?
If it is for testing purpose, I wonder wether it is worth to do it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help