On Wed, Jun 01, 2016 at 07:44:33AM +0000, Tan, Jianfeng wrote:

Hi Yuanhan,

quoted

-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
Sent: Wednesday, June 1, 2016 3:38 PM
To: Tan, Jianfeng
Cc: dev@dpdk.org; Xie, Huawei; rich.lane@bigswitch.com; mst@redhat.com;
nakajima.yoshihiro@lab.ntt.co.jp; p.fedin@samsung.com;
ann.zhuangyanying@huawei.com; mukawa@igel.co.jp;
nhorman@tuxdriver.com
Subject: Re: [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

On Mon, May 30, 2016 at 10:55:33AM +0000, Jianfeng Tan wrote:

quoted

Abstract vring hdr desc init as an inline method.

What's this patch for then? In your last version, it will be invoked
twice, but it turned out to be wrong. So, why keeping this change?
I didn't see it improves anything.

Yes, for now, only one version is kept because the position to call this function is changed. And I think this segment of code functions as a special purpose, which can be abstracted as a function, make sense?

Yeah, maybe. But idealy, we should move it to tx_queue_setup() function.
Let's see what we might do after applying Huawei's rx/tx split patch: it
needs a while (I saw bugs).

	--yliu