On Tue, Jan 12, 2016 at 10:45:59AM +0300, Pavel Fedin wrote:

 Hello!

 See inline

Hi,

Please strip unrelated context, so that people could reach to your
comments as quick as possible, otherwise, people could easily get
lost from the long patch.

quoted

-----Original Message-----
From: Jianfeng Tan [mailto:jianfeng.tan@intel.com]
+	struct rte_mbuf *m = NULL;
+	if (dev->dev_type == RTE_ETH_DEV_PCI)
+		vq->offset = (uintptr_t)&m->buf_addr;
+#ifdef RTE_VIRTIO_VDEV
+	else {
+		vq->offset = (uintptr_t)&m->buf_physaddr;

 Not sure, but shouldn't these be swapped? Originally, for PCI devices, we used buf_physaddr.

And this reply just servers as an example only :)

	--yliu