Re: [PATCH v3 5/8] vhost: claim that we support GUEST_ANNOUNCE feature
From: Olivier MATZ <hidden>
Date: 2016-03-11 12:39:56
Hi Yuanhan, On 01/29/2016 05:58 AM, Yuanhan Liu wrote:
quoted hunk ↗ jump to hunk
It's actually a feature already enabled in Linux kernel (since v3.5). What we need to do is simply to claim that we support such feature, and nothing else. With that, the guest will send an ARP message after live migration to notify the switches about the new location of migrated VM. Signed-off-by: Yuanhan Liu <redacted> Tested-by: Pavel Fedin <redacted> --- lib/librte_vhost/virtio-net.c | 1 + 1 file changed, 1 insertion(+)diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c index 03044f6..0ba5045 100644 --- a/lib/librte_vhost/virtio-net.c +++ b/lib/librte_vhost/virtio-net.c@@ -74,6 +74,7 @@ static struct virtio_net_config_ll *ll_root; #define VHOST_SUPPORTED_FEATURES ((1ULL << VIRTIO_NET_F_MRG_RXBUF) | \ (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ (1ULL << VIRTIO_NET_F_CTRL_RX) | \ + (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE) | \ (VHOST_SUPPORTS_MQ) | \ (1ULL << VIRTIO_F_VERSION_1) | \ (1ULL << VHOST_F_LOG_ALL) | \
I'm trying to compile the dpdk on an debian-7, and it fails due to this patch. Indeed, the define VIRTIO_NET_F_GUEST_ANNOUNCE is not present in /usr/include/linux/virtio_net.h on this distribution. I'm wondering if the librte_vhost shouldn't embed its own version of virtio_net.h instead of relying on the one from the distribution. It seems it has been done this way for the virtio guest PMD in dpdk.org/drivers/net/virtio/virtio_pci.h. What do you think? Thanks, Olivier