Re: [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array
From: Thomas Monjalon <hidden>
Date: 2016-02-29 15:58:20
From: Thomas Monjalon <hidden>
Date: 2016-02-29 15:58:20
2016-02-22 22:36, Yuanhan Liu:
The wrong mac table lead all the packets to the VM go to the "ovsbr0" in the end, which ends up with all packets being lost, until the guest send a ARP quest (or reply) to refresh the mac learning table. Jianfeng then came up with a solution I have thought of firstly but NAKed by myself, concerning it has potential issues [0]. The solution is as title stated: broadcast the RARP packet by injecting it to the receiving mbuf arrays at rte_vhost_dequeue_burst(). The re-bring of that idea made me think it twice; it looked like a false concern to me then. And I had done a rough verification: it worked as expected. [0]: http://dpdk.org/ml/archives/dev/2016-February/033527.html Another note is that while preparing this version, I found that DPDK has some ARP related structures and macros defined. So, use them instead of the one from standard header files here. Cc: Thibaut Collet <redacted> Suggested-by: Jianfeng Tan <redacted> Signed-off-by: Yuanhan Liu <redacted>
Applied, thanks