Re: [PATCH v3 2/8] vhost: introduce vhost_log_write
From: Thomas Monjalon <hidden>
Date: 2016-02-19 14:35:52
From: Thomas Monjalon <hidden>
Date: 2016-02-19 14:35:52
2016-01-29 12:57, Yuanhan Liu:
Introduce vhost_log_write() helper function to log the dirty pages we touched. Page size is harded code to 4096 (VHOST_LOG_PAGE), and each log is presented by 1 bit. Therefore, vhost_log_write() simply finds the right bit for related page we are gonna change, and set it to 1. dev->log_base denotes the start of the dirty page bitmap. Signed-off-by: Yuanhan Liu <redacted> Signed-off-by: Victor Kaplansky <redacted> Tested-by: Pavel Fedin <redacted>
[...]
+static inline void __attribute__((always_inline)) +vhost_log_write(struct virtio_net *dev, uint64_t addr, uint64_t len)
lib/librte_vhost/vhost_rxtx.c:59:1: error: unused function 'vhost_log_write' I think it's better to squash with the next patch.