Thread (38 messages) 38 messages, 5 authors, 2016-01-29

Re: [PATCH v5 10/11] virtio: pci: add dummy func definition for in/outb for non-x86 arch

From: Yuanhan Liu <hidden>
Date: 2016-01-29 07:38:01

On Fri, Jan 29, 2016 at 01:01:02PM +0530, Santosh Shukla wrote:
quoted
Another generic comment about this patchset is that it VERY okay to
include several components change in one set, but putting them in
order helps review a lot.

Say, this patch set has dependence on VFIO stuff, therefore, it'd be
much better __IF__ you can put all VFIO related patches first, and
then virtio related patches follows, but not in an interleaved way
you did. If, for somereason, you can't do that, you should at least
try to minimise the chance of interleave.
I agree that, but this patch series dependent on other patches
including virtio 1.0 and then vfio-noiommu, its was difficult for me
to keep topic-wise sanity in patch series.
That would not be an issue to me: just apply the dependence patches
first, and build your patches on top of that. You just need mention
the dependence info in your cover-letter.

	--yliu
V6 will take care patch ordering. Thanks
Thanks!

	--yliu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help