Thread (38 messages) read the whole thread 38 messages, 5 authors, 2016-01-29

Re: [PATCH v5 10/11] virtio: pci: add dummy func definition for in/outb for non-x86 arch

From: Santosh Shukla <hidden>
Date: 2016-01-27 10:37:37

Ping?

On Tue, Jan 19, 2016 at 5:16 PM, Santosh Shukla [off-list ref] wrote:
quoted hunk ↗ jump to hunk
For non-x86 arch, Compiler will throw build error for in/out apis. Including
dummy api function so to pass build.

Note that: For virtio to work for non-x86 arch - RTE_EAL_VFIO is the only
supported method. RTE_EAL_IGB_UIO is not supported for non-x86 arch.

So, Virtio support for arch and supported interface by that arch:

ARCH       IGB_UIO      VFIO
x86             Y       Y
ARM64           N/A     Y
PPC_64          N/A     Y       (Not tested but likely should work, as vfio is
arch independent)

Note: Applicable for virtio spec 0.95

Signed-off-by: Santosh Shukla <redacted>
---
 drivers/net/virtio/virtio_pci.h |   46 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h
index f550d22..b88f9ec 100644
--- a/drivers/net/virtio/virtio_pci.h
+++ b/drivers/net/virtio/virtio_pci.h
@@ -46,6 +46,7 @@
 #endif

 #include <rte_ethdev.h>
+#include "virtio_logs.h"

 struct virtqueue;
@@ -320,6 +321,51 @@ outl_p(unsigned int data, unsigned int port)
 }
 #endif

+#if !defined(RTE_ARCH_X86_64) && !defined(RTE_ARCH_I686) && \
+               defined(RTE_EXEC_ENV_LINUXAPP)
+static inline uint8_t
+inb(unsigned long addr __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "inb() not supported for this RTE_ARCH\n");
+       return 0;
+}
+
+static inline uint16_t
+inw(unsigned long addr __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "inw() not supported for this RTE_ARCH\n");
+       return 0;
+}
+
+static inline uint32_t
+inl(unsigned long addr __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "in() not supported for this RTE_ARCH\n");
+       return 0;
+}
+
+static inline void
+outb_p(unsigned char data __rte_unused, unsigned int port __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "outb_p() not supported for this RTE_ARCH\n");
+       return;
+}
+
+static inline void
+outw_p(unsigned short data __rte_unused, unsigned int port __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "outw_p() not supported for this RTE_ARCH\n");
+       return;
+}
+
+static inline void
+outl_p(unsigned int data __rte_unused, unsigned int port __rte_unused)
+{
+       PMD_INIT_LOG(ERR, "outl_p() not supported for this RTE_ARCH\n");
+       return;
+}
+#endif
+
 static inline int
 vtpci_with_feature(struct virtio_hw *hw, uint64_t bit)
 {
--
1.7.9.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help