Thread (38 messages) read the whole thread 38 messages, 5 authors, 2016-01-29

Re: [PATCH v5 02/11] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init()

From: Santosh Shukla <hidden>
Date: 2016-01-21 10:07:26

On Thu, Jan 21, 2016 at 3:11 PM, David Marchand [off-list ref]
wrote:
Hello Santosh,

On Tue, Jan 19, 2016 at 12:46 PM, Santosh Shukla [off-list ref]
wrote:
quoted
iopl() syscall not supported in linux-arm/arm64 so always return 0 value.

Signed-off-by: Santosh Shukla <redacted>
Acked-by: Jan Viktorin <redacted>
Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
I suppose when we will have more arches, this can be rewritten so that
iopl() check is only applied to x86 and all other arches get a 0
return.
Thats correct. And which is why I am holding my other patchset which
actually move rte_eal_xx_iopl() stuff into arch specifics. I don't wanted
to mix two topic in this series. Waiting for this series to get merged then
abstract things like, iopl() and move "sys/io.h" in arch specifics and get
rid of few ifdef X86 clutter across dpdk code.

How about such commit title ?
"eal/linux: never check iopl for arm"
even better, sending v6 change for this patch now, Thanks!

Regards,
--
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help