Re:Re: [PATCH v4] dmaengine: dw-axi-dmac: convert to clk bulk APIs

Hi Vinod,

Thanks for the review.


At 2026-09-09 20:25:02, "Vinod Koul" [off-list ref] wrote:

On 03-09-26, 09:54, Li Youhong wrote:

quoted

From: Li Youhong <redacted>

axi_dma_resume() enables cfgr_clk then core_clk. If enabling
core_clk fails, return without disabling cfgr_clk, leaking the
already-enabled clock.

Switch both clocks to the clk bulk helpers so prepare/enable
failures roll back automatically, and update probe/remove/
suspend/resume accordingly.

In dw_remove(), check clk_bulk_prepare_enable(). On failure skip
MMIO and the matching disable to avoid unbalanced clk disable;
always continue with IRQ/OF/tasklet teardown.

Hey, this doesnot apply against current code, can you rebase and send

When I rebased onto the dmaengine/next branch, I found this issue has already been fixed by commit:
c843417e6d6b ("dmaengine: dw-axi-dmac: convert clock handling to clk_bulk API")

So I will drop this patch series.

quoted

Fixes: 1fe20f1b8454 ("dmaengine: Introduce DW AXI DMAC driver")

why is this a fix?

Regarding the Fixes tag: starting from commit 1fe20f1b8454, axi_dma_resume() enables cfgr_clk 
first and then core_clk. If enabling core_clk fails, the function returns immediately without 
disabling the already enabled cfgr_clk. That is why I referenced that Fixes commit. Now that 
c843417e6d6b is in mainline, my patch is no longer needed.

Sorry for the noise.

Thanks,
Li Youhong

-- 
~Vinod