Re: [PATCH] dmaengine: ioat: depends on !UML
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-08-25 13:41:09
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-08-25 13:41:09
On Wed, 2021-08-25 at 06:36 -0700, Dan Williams wrote:
quoted
quoted
quoted
The problem here is that cpuid_eax() and cpuid_ebx() don't even exist on
[snip]
It can't compile because the arch dependencies are not stubbed out like other arch specific helpers. I think this is something to revisit if / when concepts similar to the "enqcmd" instruction appear on other archs.
I think you're confusing ioat and idxd? :) The ioat driver (which this patch is against) uses cpuid_eax() and cpuid_ebx() above, and really if a driver uses that then it can only possibly run on IA :) I'm not sure it makes sense to abstract out things such as dca_enabled_in_bios() to a general architecture thing either? johannes