Re: [PATCH] dmaengine: ioat: depends on !UML
From: Dan Williams <hidden>
Date: 2021-08-09 17:24:28
On Mon, Aug 9, 2021 at 2:25 AM Johannes Berg [off-list ref] wrote:
From: Johannes Berg <redacted> Now that UML has PCI support, this driver must depend also on !UML since it pokes at X86_64 architecture internals that don't exist on ARCH=um.
Do you really need to disable compilation of the whole driver just because an arch level helper does not exist on UML builds? Isn't there already a check for enqcmds on x86_64 to make sure the CPU is sufficiently feature enabled?
quoted hunk ↗ jump to hunk
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Johannes Berg <redacted> --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 39b5b46e880f..dc155f75926d 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig@@ -315,7 +315,7 @@ config INTEL_IDXD_PERFMON config INTEL_IOATDMA tristate "Intel I/OAT DMA support" - depends on PCI && X86_64 + depends on PCI && X86_64 && !UML select DMA_ENGINE select DMA_ENGINE_RAID select DCA --2.31.1