Re: [PATCH v3 06/16] memcg: infrastructure to match an allocation to the right cache
From: Glauber Costa <hidden>
Date: 2012-09-24 08:21:10
Also in:
linux-mm, lkml
On 09/22/2012 12:52 AM, Tejun Heo wrote:
Missed some stuff. On Tue, Sep 18, 2012 at 06:12:00PM +0400, Glauber Costa wrote:quoted
+static struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg, + struct kmem_cache *cachep) +{...quoted
+ memcg->slabs[idx] = new_cachep;...quoted
+struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep, + gfp_t gfp) +{...quoted
+ return memcg->slabs[idx];I think you need memory barriers for the above pair. Thanks.
Why is that? We'll either see a value, or NULL. If we see NULL, we assume the cache is not yet created. Not a big deal.