Thread (74 messages) 74 messages, 6 authors, 2012-10-02

Re: [PATCH v3 06/16] memcg: infrastructure to match an allocation to the right cache

From: Tejun Heo <tj@kernel.org>
Date: 2012-09-21 20:52:44
Also in: linux-mm, lkml

Missed some stuff.

On Tue, Sep 18, 2012 at 06:12:00PM +0400, Glauber Costa wrote:
+static struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
+						  struct kmem_cache *cachep)
+{
...
+	memcg->slabs[idx] = new_cachep;
...
+struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep,
+					  gfp_t gfp)
+{
...
+	return memcg->slabs[idx];
I think you need memory barriers for the above pair.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help