[Buildroot] [PATCH 07/15] package/apr-util: Use <PKG>_PER_PACKAGE_TWEAK_HOOKS
From: Yann E. MORIN <hidden>
Date: 2021-06-22 20:42:18
Herv?, All, On 2021-06-22 11:47 +0200, Herve Codina spake thusly:
On Mon, 21 Jun 2021 22:56:32 +0200 Thomas Petazzoni [off-list ref] wrote:quoted
On Mon, 21 Jun 2021 16:11:22 +0200 Herve Codina [off-list ref] wrote:quoted
rules.mk is generated by apr-util configure step and it is private to apr-util. The modification performed needs to be kept in <PKG>_POST_CONFIGURE_HOOKS.Are you sure ? Both the tweak to build-1/libtool and rules.mk were introduced in commit 84b4c19e551288911a230c2b73e96bc6e2ed12f9 to solve per-package issues. So I would strongly suspect that both of them need to be moved to APR_UTIL_PER_PACKAGE_TWEAK_HOOKS.Yes, both of them need to be done but rules.mk is generated by apr-util itself at configure step. This file is not present (not yet generated) when APR_UTIL_PER_PACKAGE_TWEAK_HOOKS are called. XXX_PER_PACKAGE_TWEAK_HOOKS are for tweaking files external to current package that leads to overwrite -> Ok for build-1/libtool rules.mk is not correct for per-package build but it is generated by apr-util package for apr-util package without any overwrites -> Keep tweak in <PKG>_POST_CONFIGURE_HOOKS.
Yes, this all makes sense now.
Also, for apr and apr-utils, we are fortunate enough that the tweak is
not required at configure time, but at build time, which so far allowed
us to use POST_CONFIGURE hooks.
However, for some other packages, we might not be so lucky, and we would
have needed pre- and -postconfigure hooks. The pre-hooks can't be used
anymore for such tweaks, because of file-overwrite detection, so we need
those earlier hook.
Makes sense, makes sense.
So, except for the naming of the variable, when you respin, you can
carry my:
Reviewed-by: Yann E. MORIN [off-list ref]
Regards,
Yann E. MORIN.
Herv? -- Herv? Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
-- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'