Re: [PATCH v5 3/6] x86/sev-es: Split up runtime #VC handler for correct state tracking

From
Joerg Roedel <joro@8bytes.org>
Date
2021-06-16 19:01:36
Also in
kvm, linux-coco, lkml
Reply to
Peter Zijlstra, 2021-06-16
Hi Peter,

sorry, missed this email before sending out v6.

On Wed, Jun 16, 2021 at 06:04:26PM +0200, Peter Zijlstra wrote:
On Mon, Jun 14, 2021 at 03:53:24PM +0200, Joerg Roedel wrote:
quoted
 _ASM_NOKPROBE(\asmsym)
 SYM_CODE_END(\asmsym)
Consistency with idtentry_mce_db would seem to suggest using \cfunc and
noist_\cfunc.

amluto, tglx: do we have strong feelings on consistency?
Yeah, but this distinction does not make sense here, as none of the #VC
handlers C functions run on the actual #VC IST stack. The from-kernel
function might run on the fall-back stack (not really possible today
unless the hypervisor does something nasty). And the difference between
the fall-back stack and the actual IST stack is, that on the fall-back
stack nesting #VC exceptions is still supported.
quoted
+	vc_handle_trap_db(regs);
It's a bit sad this does user_mode(regs) again.
Okay, I will change this according your comments.

Thanks,

	Joerg

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Thread (12 messages) 12 messages, 3 authors, last reply 2021-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help