Re: [PATCH v5 2/6] x86/sev-es: Make sure IRQs are disabled while GHCB is active
From: Joerg Roedel <joro@8bytes.org>
Date: 2021-06-15 09:38:13
Also in:
kvm, linux-coco, lkml
On Mon, Jun 14, 2021 at 06:25:18PM +0200, Borislav Petkov wrote:
Thoughts?
Okay, I tested a bit with this, it mostly works fine. The lockdep_hardirqs_disabled() check in __sev_get/put_ghcb() was problematic, because these functions are called also when no state is set up yet. More specifically it is called from __sev_es_nmi_complete(), which is called at the very beginning of do_nmi(), before the NMI handler entered NMI mode. So this triggered a warning in the NMI test-suite when booting up, I replaced these checks with a WARN_ON(!irqs_disabled()) and also removed the BUG_ON()s. With that it boots fine and without SEV-ES related warnings. Regards, Joerg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization