Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-02-10 12:19:45
Also in:
lkml
On Wed, Feb 10, 2021 at 12:17:19PM +0800, Jason Wang wrote:
On 2021/2/9 下午5:00, Stefano Garzarella wrote:quoted
On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:quoted
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:quoted
It's legal to have 'offset + len' equal to sizeof(struct virtio_net_config), since 'ndev->config' is a 'struct virtio_net_config', so we can safely copy its content under this condition. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Cc: stable@vger.kernel.org Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>Acked-by: Eli Cohen <redacted> BTW, same error in vdpa_sim you may want to fix.Commit 65b709586e22 ("vdpa_sim: add get_config callback in vdpasim_dev_attr") unintentionally solved it. Since it's a simulator, maybe we can avoid solving it in the stable branches. Or does it matter?I think not, since the module depends on RUNTIME_TESTING_MENU. Thanks
Well people use the simulator for development... I'm not going to block this patch on it, but if someone has the cycles to post a stable branch patch, that would be great.
quoted
Thanks, Stefano
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization