Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

4 messages, 3 authors, 2021-02-11 · open the first message on its own page

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2021-02-09 09:09:26 

On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
quoted
It's legal to have 'offset + len' equal to
sizeof(struct virtio_net_config), since 'ndev->config' is a
'struct virtio_net_config', so we can safely copy its content under
this condition.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eli Cohen <redacted>

BTW, same error in vdpa_sim you may want to fix.
Commit 65b709586e22 ("vdpa_sim: add get_config callback in 
vdpasim_dev_attr") unintentionally solved it.

Since it's a simulator, maybe we can avoid solving it in the stable 
branches. Or does it matter?

Thanks,
Stefano
quoted
---
 drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index dc88559a8d49..10e9b09932eb 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1820,7 +1820,7 @@ static void mlx5_vdpa_get_config(struct vdpa_device *vdev, unsigned int offset,
 	struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
 	struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);

-	if (offset + len < sizeof(struct virtio_net_config))
+	if (offset + len <= sizeof(struct virtio_net_config))
 		memcpy(buf, (u8 *)&ndev->config + offset, len);
 }

--
2.29.2
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

From: Jason Wang <hidden>
Date: 2021-02-10 04:19:22 

On 2021/2/9 下午5:00, Stefano Garzarella wrote:
On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
quoted
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
quoted
It's legal to have 'offset + len' equal to
sizeof(struct virtio_net_config), since 'ndev->config' is a
'struct virtio_net_config', so we can safely copy its content under
this condition.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 
devices")
Cc: stable@vger.kernel.org
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eli Cohen <redacted>

BTW, same error in vdpa_sim you may want to fix.
Commit 65b709586e22 ("vdpa_sim: add get_config callback in 
vdpasim_dev_attr") unintentionally solved it.

Since it's a simulator, maybe we can avoid solving it in the stable 
branches. Or does it matter?

I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks




Thanks,
Stefano 
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-02-10 12:19:45 

On Wed, Feb 10, 2021 at 12:17:19PM +0800, Jason Wang wrote:
On 2021/2/9 下午5:00, Stefano Garzarella wrote:
quoted
On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
quoted
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
quoted
It's legal to have 'offset + len' equal to
sizeof(struct virtio_net_config), since 'ndev->config' is a
'struct virtio_net_config', so we can safely copy its content under
this condition.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported
mlx5 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eli Cohen <redacted>

BTW, same error in vdpa_sim you may want to fix.
Commit 65b709586e22 ("vdpa_sim: add get_config callback in
vdpasim_dev_attr") unintentionally solved it.

Since it's a simulator, maybe we can avoid solving it in the stable
branches. Or does it matter?

I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks
Well people use the simulator for development...
I'm not going to block this patch on it, but if someone
has the cycles to post a stable branch patch, that would be
great.


quoted
Thanks,
Stefano
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization





  

    
Re: [PATCH] vdpa/mlx5: fix param validation in mlx5_vdpa_get_config()

    

      From: Stefano Garzarella <sgarzare@redhat.com>

      Date: 2021-02-11 16:53:32 
    

  

  
On Wed, Feb 10, 2021 at 07:12:31AM -0500, Michael S. Tsirkin wrote:
On Wed, Feb 10, 2021 at 12:17:19PM +0800, Jason Wang wrote:
quoted
On 2021/2/9 下午5:00, Stefano Garzarella wrote:
quoted
On Tue, Feb 09, 2021 at 07:43:02AM +0200, Eli Cohen wrote:
quoted
On Mon, Feb 08, 2021 at 05:17:41PM +0100, Stefano Garzarella wrote:
quoted
It's legal to have 'offset + len' equal to
sizeof(struct virtio_net_config), since 'ndev->config' is a
'struct virtio_net_config', so we can safely copy its content under
this condition.

Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported
mlx5 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Acked-by: Eli Cohen <redacted>

BTW, same error in vdpa_sim you may want to fix.
Commit 65b709586e22 ("vdpa_sim: add get_config callback in
vdpasim_dev_attr") unintentionally solved it.

Since it's a simulator, maybe we can avoid solving it in the stable
branches. Or does it matter?

I think not, since the module depends on RUNTIME_TESTING_MENU.

Thanks
Well people use the simulator for development...
I'm not going to block this patch on it, but if someone
has the cycles to post a stable branch patch, that would be
great.
Okay, I'll do it.

Thanks,
Stefano

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help