Re: [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2020-08-05 17:05:15
Also in:
lkml, platform-driver-x86
On Tue, Aug 04, 2020 at 04:56:34PM +0200, Cornelia Huck wrote:
On Mon, 3 Aug 2020 17:00:01 -0400 "Michael S. Tsirkin" [off-list ref] wrote:quoted
mlxbf-tmfifo accesses config space using native types - which works for it since the legacy virtio native types. This will break if it ever needs to support modern virtio, so with new tags previously introduced for virtio net config, sparse now warns for this in drivers. Since this is a legacy only device, fix it up using virtio_legacy_is_little_endian for now.I'm wondering if the driver should make this more explicit?
Not sure how though.
No issues with the patch, though.quoted
No functional changes. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)Acked-by: Cornelia Huck <cohuck@redhat.com>
_______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization