Thread (69 messages) flat view 69 messages, 7 authors, 2020-08-07

Re: [PATCH v2 05/24] virtio_balloon: correct tags for config space fields

From: David Hildenbrand <hidden>
Date: 2020-08-03 21:26:54
Also in: lkml

Am 03.08.2020 um 22:59 schrieb Michael S. Tsirkin [off-list ref]:

Tag config space fields as having little endian-ness.
Note that balloon is special: LE even when using
the legacy interface.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: David Hildenbrand <redacted>
quoted hunk ↗ jump to hunk
---
include/uapi/linux/virtio_balloon.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
index dc3e656470dd..ddaa45e723c4 100644
--- a/include/uapi/linux/virtio_balloon.h
+++ b/include/uapi/linux/virtio_balloon.h
@@ -45,20 +45,20 @@
#define VIRTIO_BALLOON_CMD_ID_DONE    1
struct virtio_balloon_config {
   /* Number of pages host wants Guest to give up. */
-    __u32 num_pages;
+    __le32 num_pages;
   /* Number of pages we've actually got in balloon. */
-    __u32 actual;
+    __le32 actual;
   /*
    * Free page hint command id, readonly by guest.
    * Was previously named free_page_report_cmd_id so we
    * need to carry that name for legacy support.
    */
   union {
-        __u32 free_page_hint_cmd_id;
-        __u32 free_page_report_cmd_id;    /* deprecated */
+        __le32 free_page_hint_cmd_id;
+        __le32 free_page_report_cmd_id;    /* deprecated */
   };
   /* Stores PAGE_POISON if page poisoning is in use */
-    __u32 poison_val;
+    __le32 poison_val;
};

#define VIRTIO_BALLOON_S_SWAP_IN  0   /* Amount of memory swapped in */
-- 
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help