Re: [PATCH 62/62] x86/sev-es: Add NMI state tracking
flat view
From: Andy Lutomirski <luto@kernel.org>
Date: 2020-02-11 22:50:44
Also in:
kvm, lkml
On Tue, Feb 11, 2020 at 5:53 AM Joerg Roedel [off-list ref] wrote:
From: Joerg Roedel <redacted> Keep NMI state in SEV-ES code so the kernel can re-enable NMIs for the vCPU when it reaches IRET.
This patch is overcomplicated IMO. Just do the magic incantation in C
from do_nmi or from here:
/*
* For ease of testing, unmask NMIs right away. Disabled by
* default because IRET is very expensive.
If you do the latter, you'll need to handle the case where the NMI
came from user mode.
The ideal solution is do_nmi, I think.
if (static_cpu_has(X86_BUG_AMD_FORGOT_ABOUT_NMI))
sev_es_unmask_nmi();
Feel free to use X86_FEATURE_SEV_ES instead :)
--Andu