Re: DANGER WILL ROBINSON, DANGER

On Tue, Aug 13, 2019 at 11:29:07AM +0200, Paolo Bonzini wrote:

On 09/08/19 18:24, Matthew Wilcox wrote:

quoted

On Fri, Aug 09, 2019 at 07:00:26PM +0300, Adalbert Lazăr wrote:

quoted

+++ b/include/linux/page-flags.h

@@ -417,8 +417,10 @@ PAGEFLAG(Idle, idle, PF_ANY)
  */
 #define PAGE_MAPPING_ANON	0x1
 #define PAGE_MAPPING_MOVABLE	0x2
+#define PAGE_MAPPING_REMOTE	0x4

Uh.  How do you know page->mapping would otherwise have bit 2 clear?
Who's guaranteeing that?

This is an awfully big patch to the memory management code, buried in
the middle of a gigantic series which almost guarantees nobody would
look at it.  I call shenanigans.

Are you calling shenanigans on the patch submitter (which is gratuitous)
or on the KVM maintainers/reviewers?

On the patch submitter, of course.  How can I possibly be criticising you
for something you didn't do?

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization