Re: [RFC PATCH v6 14/92] kvm: introspection: handle introspection commands before returning to guest
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2019-08-13 08:26:36
Also in:
kvm, linux-mm
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2019-08-13 08:26:36
Also in:
kvm, linux-mm
On 09/08/19 17:59, Adalbert Lazăr wrote:
+ prepare_to_swait_exclusive(&vcpu->wq, &wait,
+ TASK_INTERRUPTIBLE);
+
+ if (kvm_vcpu_check_block(vcpu) < 0)
+ break;
+
+ waited = true;
+ schedule();
+
+ if (kvm_check_request(KVM_REQ_INTROSPECTION, vcpu)) {
+ do_kvmi_work = true;
+ break;
+ }
+ }
- waited = true;
- schedule();
+ finish_swait(&vcpu->wq, &wait);
+
+ if (do_kvmi_work)
+ kvmi_handle_requests(vcpu);
+ else
+ break;
}Is this needed? Or can it just go back to KVM_RUN and handle KVM_REQ_INTROSPECTION there (in which case it would be basically premature optimization)? Paolo _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization