Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing
From: Jason Wang <jasowang@redhat.com>
Date: 2016-12-26 02:30:19
Also in:
lkml, netdev
From: Jason Wang <jasowang@redhat.com>
Date: 2016-12-26 02:30:19
Also in:
lkml, netdev
On 2016年12月23日 23:54, John Fastabend wrote:
On 16-12-23 06:37 AM, Jason Wang wrote:quoted
We don't put page during linearizing, the would cause leaking when xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by put page accordingly. Also decrease the number of buffers during linearizing to make sure caller can free buffers correctly when packet exceeds PAGE_SIZE. With this patch, we won't get OOM after linearize huge number of packets. Cc: John Fastabend <redacted> Signed-off-by: Jason Wang <jasowang@redhat.com> ---Thanks! looks good. By the way do you happen to have any actual configuration where this path is hit? I obviously didn't test this very long other than a quick test with my hacked vhost driver. Acked-by: John Fastabend <redacted>
Yes, I have. Just increase the MTU above 1500 for both virtio and tap and produce some traffic with size which will lead underestimated of rxbuf. Thanks _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization