Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing

From
John Fastabend <john.fastabend@gmail.com>
Date
2016-12-23 15:54:30
Also in
lkml, netdev
Reply to
Jason Wang, 2016-12-23
On 16-12-23 06:37 AM, Jason Wang wrote:
We don't put page during linearizing, the would cause leaking when
xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by
put page accordingly. Also decrease the number of buffers during
linearizing to make sure caller can free buffers correctly when packet
exceeds PAGE_SIZE. With this patch, we won't get OOM after linearize
huge number of packets.

Cc: John Fastabend <redacted>
Signed-off-by: Jason Wang <redacted>
---
Thanks! looks good. By the way do you happen to have any actual
configuration where this path is hit? I obviously didn't test this
very long other than a quick test with my hacked vhost driver.

Acked-by: John Fastabend <redacted>
Thread (29 messages) 29 messages, 4 authors, last reply 2017-01-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help