Thread (21 messages) 21 messages, 2 authors, 2013-08-30

Re: [PATCH 2/6] vhost_net: use vhost_add_used_and_signal_n() in vhost_zerocopy_signal_used()

From: Jason Wang <hidden>
Date: 2013-08-20 02:33:14
Also in: kvm, lkml, netdev

On 08/16/2013 05:54 PM, Michael S. Tsirkin wrote:
On Fri, Aug 16, 2013 at 01:16:26PM +0800, Jason Wang wrote:
quoted
quoted
Switch to use vhost_add_used_and_signal_n() to avoid multiple calls to
vhost_add_used_and_signal(). With the patch we will call at most 2 times
(consider done_idx warp around) compared to N times w/o this patch.

Signed-off-by: Jason Wang <redacted>
So? Does this help performance then?
Looks like it can especially when guest does support event index. When
guest enable tx interrupt, this can saves us some unnecessary signal to
guest. I will do some test.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help