From: Asias He <redacted>
Date: Fri, 16 Aug 2013 17:27:43 +0800

On Fri, Aug 16, 2013 at 12:31:59AM -0700, David Miller wrote:

quoted

From: Asias He <redacted>
Date: Fri, 16 Aug 2013 09:27:43 +0800

quoted

On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:

quoted

From: Asias He <redacted>
Date: Thu, 15 Aug 2013 11:20:16 +0800

quoted

memcpy_fromiovec is moved to lib/iovec.c. No need to include
linux/socket.h for it.

Signed-off-by: Asias He <redacted>

You can't do this.

Because this file doesn't include the header file that
provides the declaration, which is linux/uio.h

vhost.c includes drivers/vhost/vhost.h. In drivers/vhost/vhost.h, we
have linux/uio.h included.

Nothing in vhost.h needs linux/uio.h right?  That's very poor style,
include the header where the dependency exists which is vhost.c

We use 'struct iovec' in vhost.h which needs linux/uio.h, no?

So, how about including linux/uio.h in both vhost.c and vhost.h.

That sounds good.