Re: [PATCH] vhost: Drop linux/socket.h

[PATCH] vhost: Drop linux/socket.h · Asias He <hidden> · 2013-08-15
Re: [PATCH] vhost: Drop linux/socket.h · David Miller <davem@davemloft.net> · 2013-08-15
Re: [PATCH] vhost: Drop linux/socket.h · Asias He <hidden> · 2013-08-16
Re: [PATCH] vhost: Drop linux/socket.h · David Miller <davem@davemloft.net> · 2013-08-16
Re: [PATCH] vhost: Drop linux/socket.h · Asias He <hidden> · 2013-08-16
Re: [PATCH] vhost: Drop linux/socket.h · David Miller <davem@davemloft.net> · 2013-08-17
[PATCH v2] vhost: Include linux/uio.h instead of linux/socket.h · Asias He <hidden> · 2013-08-19
Re: [PATCH v2] vhost: Include linux/uio.h instead of linux/socket.h · "Michael S. Tsirkin" <mst@redhat.com> · 2013-08-19
Re: [PATCH v2] vhost: Include linux/uio.h instead of linux/socket.h · David Miller <davem@davemloft.net> · 2013-08-20
Re: [PATCH] vhost: Drop linux/socket.h · "Michael S. Tsirkin" <mst@redhat.com> · 2013-08-16

From: David Miller <davem@davemloft.net>
Date: 2013-08-16 07:31:59
Also in: kvm, netdev

From: Asias He <redacted>
Date: Fri, 16 Aug 2013 09:27:43 +0800

On Thu, Aug 15, 2013 at 02:07:40PM -0700, David Miller wrote:

quoted

From: Asias He <redacted>
Date: Thu, 15 Aug 2013 11:20:16 +0800

quoted

memcpy_fromiovec is moved to lib/iovec.c. No need to include
linux/socket.h for it.

Signed-off-by: Asias He <redacted>

You can't do this.

Because this file doesn't include the header file that
provides the declaration, which is linux/uio.h

vhost.c includes drivers/vhost/vhost.h. In drivers/vhost/vhost.h, we
have linux/uio.h included.

Nothing in vhost.h needs linux/uio.h right?  That's very poor style,
include the header where the dependency exists which is vhost.c