Thread (22 messages) flat view 22 messages, 3 authors, 2012-09-19

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

From: Rusty Russell <hidden>
Date: 2012-09-12 06:33:31
Also in: lkml

Possibly related (same subject, not in this thread)

"Michael S. Tsirkin" [off-list ref] writes:
quoted
virtio: don't crash when device is buggy

Because of a sanity check in virtio_dev_remove, a buggy device can crash
kernel.  And in case of rproc it's userspace so it's not a good idea.
We are unloading a driver so how bad can it be?
Be less aggressive in handling this error: if it's a driver bug,
warning once should be enough.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Rusty?
Thanks, applied.

I really want to implement CONFIG_VIRTIO_DEVEL_DEBUG which would
incorporate the checks in virtio_ring.c as well as this.  Then I could
also reshuffle descriptors (eg. split them) to find buggy devices like
qemu which assume the first descriptor is the struct virtio_net_hdr...

Cheers,
Rusty,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help