Thread (22 messages) flat view 22 messages, 3 authors, 2012-09-19

Re: [RFC 1/2] virtio_console: Add support for DMA memory allocation

From: Rusty Russell <hidden>
Date: 2012-09-04 23:10:25
Also in: lkml

Possibly related (same subject, not in this thread)

"Michael S. Tsirkin" [off-list ref] writes:
Also let's add a wrapper at top of file so ifdefs
do not litter the code like this. For example:

#ifdef CONFIG_HAS_DMA
#define VIRTIO_CONSOLE_HAS_DMA (1)
#else
#define VIRTIO_CONSOLE_HAS_DMA (0)
#endif

Now use if instead of ifdef.
The driver certainly shouldn't offer VIRTIO_CONSOLE_F_DMA_MEM if you
don't have DMA!

Cheers,
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help