Re: [net-next RFC V5 5/5] virtio_net: support negotiating the number of queues through ctrl vq
From: Jason Wang <jasowang@redhat.com>
Date: 2012-07-06 07:44:57
Also in:
kvm, lkml, netdev
From: Jason Wang <jasowang@redhat.com>
Date: 2012-07-06 07:44:57
Also in:
kvm, lkml, netdev
On 07/06/2012 04:07 AM, Amos Kong wrote:
On 07/05/2012 08:51 PM, Sasha Levin wrote:quoted
On Thu, 2012-07-05 at 18:29 +0800, Jason Wang wrote:quoted
@@ -1387,6 +1404,10 @@ static int virtnet_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) vi->has_cvq = true;quoted
quoted
+ /* Use single tx/rx queue pair as default */ + vi->num_queue_pairs = 1; + vi->total_queue_pairs = num_queue_pairs;vi->total_queue_pairs also should be set to 1 vi->total_queue_pairs = 1;
Hi Amos: total_queue_pairs is the max number of queue pairs that the deivce could provide, so it's ok here.
quoted
The code is using this "default" even if the amount of queue pairs it wants was specified during initialization. This basically limits any device to use 1 pair when starting up. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html