Re: [PATCH 3/3] virtio-blk: Add bio-based IO path for virtio-blk

Hello, guys.

On Mon, Jun 18, 2012 at 07:35:22PM +0930, Rusty Russell wrote:

On Mon, 18 Jun 2012 16:03:23 +0800, Asias He [off-list ref] wrote:

quoted

On 06/18/2012 03:46 PM, Rusty Russell wrote:

quoted

On Mon, 18 Jun 2012 14:53:10 +0800, Asias He [off-list ref] wrote:

quoted

This patch introduces bio-based IO path for virtio-blk.

Why make it optional?

request-based IO path is useful for users who do not want to bypass the 
IO scheduler in guest kernel, e.g. users using spinning disk. For users 
using fast disk device, e.g. SSD device, they can use bio-based IO path.

Users using a spinning disk still get IO scheduling in the host though.
What benefit is there in doing it in the guest as well?

Another thing is that some of cgroup features are impelmented in IO
scheduler (cfq).  e.g. bio based driver will be able to use cgroup
based throttling but IO weights won't work.  Not sure how meaningful
this is tho.

With that said, I think this sort of feature switching is quite ugly.
The pros and cons of each choice aren't obvious unless one is familiar
with implementation details.  IMHO, if the benefits of ioscheds aren't
critical, it would be better to just go with bio based implementation.

Thanks.

-- 
tejun