On Sat, Oct 29, 2011 at 12:54:34AM +0200, Jesper Juhl wrote:

quoted

+			default:
+				pr_err("unhandled packet type %d, tid %llx len %d\n",
+				   desc->type,
+				   req_id,
+				   bytes_recvd);

Why not:

                                pr_err("unhandled packet type %d, tid %llx 
                                       len %d\n", desc->type, req_id, bytes_recvd);

Because then the printk would be messed up?  Your final printed
string would look like:

"unhandled packet type %d, tid %llx 
                                       len %d\n"

Don't break strings up across lines because it breaks grep.  If K. Y.
wants to put all the parameters on one line instead of three that
would probably be better, but in the end who cares?

regards,
dan carpenter