Thread (33 messages) 33 messages, 6 authors, 2008-06-21

Re: [PATCH 1 of 4] mm: add a ptep_modify_prot transaction abstraction

From: Jeremy Fitzhardinge <hidden>
Date: 2008-06-20 19:07:11
Also in: lkml, xen-devel

Ingo Molnar wrote:
* Ingo Molnar [off-list ref] wrote:

  
quoted
* Linus Torvalds [off-list ref] wrote:

    
quoted
On Thu, 19 Jun 2008, Ingo Molnar wrote:
      
quoted
Below is the commit, it needed a small amount of massaging to apply the 
void * -> unsigned long * change in the x86/bitops topic.
        
Well, that's your bug right there.

The macros very much depended on the pointers being "void *", due to 
the pointer arithmetic (which is a gcc extension that we use 
extensively - "void *" arithmetic works as if it was a byte 
pointer).
      
duh, yeah - of course. Will retry with that fixed :)
    
yep, the patch below got it all going and it passed 5 hours of testing 
already. Thanks,
  
Blows up on "gcc version 3.4.4 20050314 (prerelease) (Debian 3.4.3-13)":

  CC      init/main.o
include2/asm/bitops.h: In function `start_kernel':
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: warning: asm operand 1 probably doesn't match constraints
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'
include2/asm/bitops.h:59: error: impossible constraint in `asm'

	J
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help