On Wed, 2007-05-09 at 15:13 +0300, Pekka Enberg wrote:

Hi Rusty,

On 5/9/07, Rusty Russell [off-list ref] wrote:

quoted

        Hmm, where would the error go?

Let it propagate: scan_devices -> lguest_bus_init -> do_initcalls. We
probably don't want to panic() if bus_register and device_register
fail there either.

Hi Pekka,

	Hey, thanks, I didn't realize that do_initcalls() now takes some note
when an initcall fails.  But I'm pretty sure a local error message is
more informative than "initcall at 0xc0123408: returned with error code
2" etc.

	And I agree about the panic: bus_register and device_register should
panic for us if they fail this early in boot.  But I don't think they
do...

Thanks,
Rusty.