Re: [patch 2/9] lguest: the guest code
From: Pekka Enberg <hidden>
Date: 2007-05-09 10:16:33
Also in:
lkml
From: Pekka Enberg <hidden>
Date: 2007-05-09 10:16:33
Also in:
lkml
Hi Rusty, On 5/9/07, akpm@linux-foundation.org [off-list ref] wrote:
+static void add_lguest_device(unsigned int index)
+{
+ struct lguest_device *new;
+
+ lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE;
+ new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL);
+ if (!new) {
+ printk(KERN_EMERG "Cannot allocate lguest device %u\n", index);
+ lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED;[snip] Any reason why we don't return an error here?