Re: [PATCH] Use correct macros in raid code, not raw asm
From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2007-02-09 01:21:22
Also in:
lkml
From: "H. Peter Anvin" <hpa@zytor.com>
Date: 2007-02-09 01:21:22
Also in:
lkml
Andi Kleen wrote:
quoted
The code looks like it's designed to be included from userspace for testing; as it compiles without this include (and has no other includes), I chose not to add it. Linus makes a good point, but someone who actually knows the code should, y'know, test it and stuff...It should use kernel_fpu_begin() imho. If someone wants to test it in user space again they can add dummy definitions of that to their user space header.
I hadn't seen this thread until now, when Neil pointed me to the thread. Using kernel_fpu_begin() ... kernel_fpu_end() is probably indeed the best option. -hpa