Re: [PATCH] Use correct macros in raid code, not raw asm
From: Andrew Morton <hidden>
Date: 2006-12-28 23:57:44
Also in:
lkml
On Fri, 29 Dec 2006 10:34:21 +1100 Rusty Russell [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This make sure it's paravirtualized correctly when CONFIG_PARAVIRT=y. Signed-off-by: Rusty Russell <redacted> diff -r 4ff048622391 drivers/md/raid6x86.h--- a/drivers/md/raid6x86.h Thu Dec 28 16:52:54 2006 +1100 +++ b/drivers/md/raid6x86.h Fri Dec 29 10:09:38 2006 +1100@@ -75,13 +75,14 @@ static inline unsigned long raid6_get_fp unsigned long cr0; preempt_disable(); - asm volatile("mov %%cr0,%0 ; clts" : "=r" (cr0)); + cr0 = read_cr0(); + clts(); return cr0; } static inline void raid6_put_fpu(unsigned long cr0) { - asm volatile("mov %0,%%cr0" : : "r" (cr0)); + write_cr0(cr0); preempt_enable(); }
Perhaps we also need:
--- a/drivers/md/raid6x86.h~use-correct-macros-in-raid-code-not-raw-asm-include
+++ a/drivers/md/raid6x86.h@@ -21,6 +21,8 @@ #if defined(__i386__) || defined(__x86_64__) +#include <asm/system.h> + #ifdef __x86_64__ typedef struct {
_ ?