Re: [PATCH] bus: mhi: pci_generic: increase timeout value for operations to 24000ms

On Thu, Sep 30, 2021 at 10:07:57AM +0200, Thomas Perrot wrote:

Hello,

[...]

I made experimentation on a Sierra EM9190 (SDX55) engineering sample,
using a old development firmware.

So, I agree that setting the same timeout of 24000ms for all modems, is
not necessarily relevant.
However, the current default value seems too low, in view of timeouts
used on vendor-branded, then using a higher value seems relevant.

Moreover, Sierra EM919x modems use a custom controller configuration,
we are currently working on it. As our tests not being sufficiently
conclusive, so we have not yet submitted.

Okay. Then please add a separate config for this device when you have it. It
makes more sense to have the longer timeout only for devices that need it.

Thanks,
Mani

Best regards,
Thomas

quoted

quoted

It was derived from testing I believe.

Following your reasoning above, shouldn't this 24000ms timeout be
applied only to the Sierra Wireless EM91xx devices (which may have
custom firmware bits delaying the initialization a bit longer), and
not to the generic SDX24, SDX55 and SDX65?

If I'm not mistaken, Thomas is testing with a custom mhi_pci_generic
entry for the EM91xx; as in
https://forum.sierrawireless.com/t/sierra-wireless-airprime-em919x-pcie-support/24927
.
I'm also playing with that same entry on my own setup, but have other
problems of my own :)


--
Aleksander
https://aleksander.es

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com