Thread (6 messages) flat view 6 messages, 4 authors, 2021-06-18

Re: [PATCH] cxgb4: fix wrong shift.

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-15 10:17:22
Also in: lkml, netdev

On Tue, Jun 15, 2021 at 11:56:51AM +0200, Pavel Machek wrote:
quoted hunk ↗ jump to hunk
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
 				      WORD_MASK, f->fs.nat_lip[3] |
 				      f->fs.nat_lip[2] << 8 |
 				      f->fs.nat_lip[1] << 16 |
-				      (u64)f->fs.nat_lip[0] << 25, 1);
+				      (u64)f->fs.nat_lip[0] << 24, 1);
 		}
 	}
 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help