[PATCH] cxgb4: fix wrong shift.

Subsystems: cxgb4 ethernet driver (cxgb4), networking drivers, the rest

STALE1878d

6 messages, 4 authors, 2021-06-18 · open the first message on its own page

[PATCH] cxgb4: fix wrong shift.

From: Pavel Machek <hidden>
Date: 2021-06-15 09:56:56

While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
 				      WORD_MASK, f->fs.nat_lip[3] |
 				      f->fs.nat_lip[2] << 8 |
 				      f->fs.nat_lip[1] << 16 |
-				      (u64)f->fs.nat_lip[0] << 25, 1);
+				      (u64)f->fs.nat_lip[0] << 24, 1);
 		}
 	}
 

Re: [PATCH] cxgb4: fix wrong shift.

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-06-15 10:17:22

On Tue, Jun 15, 2021 at 11:56:51AM +0200, Pavel Machek wrote:
quoted hunk
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
 				      WORD_MASK, f->fs.nat_lip[3] |
 				      f->fs.nat_lip[2] << 8 |
 				      f->fs.nat_lip[1] << 16 |
-				      (u64)f->fs.nat_lip[0] << 25, 1);
+				      (u64)f->fs.nat_lip[0] << 24, 1);
 		}
 	}
 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH] cxgb4: fix wrong shift.

From: David Miller <davem@davemloft.net>
Date: 2021-06-15 18:22:50

From: Pavel Machek <redacted>
Date: Tue, 15 Jun 2021 11:56:51 +0200
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
Please repost with an appropriate Fixes: tag, thank you.

[PATCHv2] cxgb4: fix wrong shift.

From: Pavel Machek <hidden>
Date: 2021-06-18 09:29:56

While fixing coverity warning, commit dd2c79677375 introduced typo in
shift value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 22c9ac922eba..6260b3bebd2b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -198,7 +198,7 @@ static void set_nat_params(struct adapter *adap, struct filter_entry *f,
 				      WORD_MASK, f->fs.nat_lip[3] |
 				      f->fs.nat_lip[2] << 8 |
 				      f->fs.nat_lip[1] << 16 |
-				      (u64)f->fs.nat_lip[0] << 25, 1);
+				      (u64)f->fs.nat_lip[0] << 24, 1);
 		}
 	}
 

Re: [PATCH] cxgb4: fix wrong shift.

From: Pavel Machek <hidden>
Date: 2021-06-18 09:31:06

On Tue 2021-06-15 11:22:42, David Miller wrote:
From: Pavel Machek <redacted>
Date: Tue, 15 Jun 2021 11:56:51 +0200
quoted
While fixing coverity warning, commit
dd2c79677375c37f8f9f8d663eb4708495d595ef introduced typo in shift
value. Fix that.
    
Signed-off-by: Pavel Machek (CIP) <redacted>
Please repost with an appropriate Fixes: tag, thank you.
Done, you should have PATCHv2 in your inbox.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCHv2] cxgb4: fix wrong shift.

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-06-18 19:00:07

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 18 Jun 2021 11:29:48 +0200 you wrote:
While fixing coverity warning, commit dd2c79677375 introduced typo in
shift value. Fix that.

Signed-off-by: Pavel Machek (CIP) <redacted>
Fixes: dd2c79677375 ("cxgb4: Fix unintentional sign extension issues")
Here is the summary with links:
  - [PATCHv2] cxgb4: fix wrong shift.
    https://git.kernel.org/netdev/net/c/39eb028183bc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help