[PATCH 5.10 018/157] zonefs: fix to update .i_wr_refcnt correctly in zonefs_open_zone()
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-03-22 12:41:24
Also in:
lkml
From: Chao Yu <redacted>
commit 6980d29ce4da223ad7f0751c7f1d61d3c6b54ab3 upstream.
In zonefs_open_zone(), if opened zone count is larger than
.s_max_open_zones threshold, we missed to recover .i_wr_refcnt,
fix this.
Fixes: b5c00e975779 ("zonefs: open/close zone on file open/close")
Cc: <redacted>
Signed-off-by: Chao Yu <redacted>
Signed-off-by: Damien Le Moal <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/zonefs/super.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c@@ -1032,9 +1032,7 @@ static int zonefs_open_zone(struct inode mutex_lock(&zi->i_truncate_mutex); - zi->i_wr_refcnt++; - if (zi->i_wr_refcnt == 1) { - + if (!zi->i_wr_refcnt) { if (atomic_inc_return(&sbi->s_open_zones) > sbi->s_max_open_zones) { atomic_dec(&sbi->s_open_zones); ret = -EBUSY;
@@ -1044,7 +1042,6 @@ static int zonefs_open_zone(struct inode if (i_size_read(inode) < zi->i_max_size) { ret = zonefs_zone_mgmt(inode, REQ_OP_ZONE_OPEN); if (ret) { - zi->i_wr_refcnt--; atomic_dec(&sbi->s_open_zones); goto unlock; }
@@ -1052,6 +1049,8 @@ static int zonefs_open_zone(struct inode } } + zi->i_wr_refcnt++; + unlock: mutex_unlock(&zi->i_truncate_mutex);