Thread (106 messages) 106 messages, 6 authors, 2021-03-18
STALE1932d REVIEWED: 2 (0M)

[PATCH 4.14 12/95] cifs: return proper error code in statfs(2)

From: gregkh@linuxfoundation.org
Date: 2021-03-15 14:30:46
Also in: lkml

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

From: Paulo Alcantara <redacted>

commit 14302ee3301b3a77b331cc14efb95bf7184c73cc upstream.

In cifs_statfs(), if server->ops->queryfs is not NULL, then we should
use its return value rather than always returning 0.  Instead, use rc
variable as it is properly set to 0 in case there is no
server->ops->queryfs.

Signed-off-by: Paulo Alcantara (SUSE) <redacted>
Reviewed-by: Aurelien Aptel <redacted>
Reviewed-by: Ronnie Sahlberg <redacted>
CC: <redacted>
Signed-off-by: Steve French <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/cifs/cifsfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/cifs/cifsfs.c
+++ b/fs/cifs/cifsfs.c
@@ -214,7 +214,7 @@ cifs_statfs(struct dentry *dentry, struc
 		rc = server->ops->queryfs(xid, tcon, buf);
 
 	free_xid(xid);
-	return 0;
+	return rc;
 }
 
 static long cifs_fallocate(struct file *file, int mode, loff_t off, loff_t len)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help