[PATCH 4.8 040/125] rt2x00usb: Fix error return code
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2016-10-29 14:15:57
Also in:
lkml
4.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christophe Jaillet <redacted>
commit 410280bac6224e066f4cf0b87db08f0418a135b6 upstream.
We know that 'retval = 0' because it has been tested a few lines above.
So, if 'devm_kmalloc' fails, 0 will be returned instead of an error code.
Return -ENOMEM instead.
Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB")
Signed-off-by: Christophe JAILLET <redacted>
Acked-by: Stanislaw Gruszka <redacted>
Signed-off-by: Kalle Valo <redacted>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/net/wireless/ralink/rt2x00/rt2x00usb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00usb.c@@ -831,8 +831,10 @@ int rt2x00usb_probe(struct usb_interface rt2x00dev->anchor = devm_kmalloc(&usb_dev->dev, sizeof(struct usb_anchor), GFP_KERNEL); - if (!rt2x00dev->anchor) + if (!rt2x00dev->anchor) { + retval = -ENOMEM; goto exit_free_reg; + } init_usb_anchor(rt2x00dev->anchor); return 0;