Thread (115 messages) 115 messages, 3 authors, 2016-10-30
STALE3557d

[PATCH 4.8 061/125] ASoC: topology: Fix error return code in soc_tplg_dapm_widget_create()

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2016-10-29 13:52:53
Also in: lkml

4.8-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Wei Yongjun <redacted>

commit 8ae3ea48df0d746b663057cf0b972a18d0777b7b upstream.

Fix to return error code -ENOMEM instead of 0 when failed to create
widget, as done elsewhere in this function.

Fixes: 8a9782346dcc ("ASoC: topology: Add topology core")
Signed-off-by: Wei Yongjun <redacted>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 sound/soc/soc-topology.c |    1 +
 1 file changed, 1 insertion(+)
--- a/sound/soc/soc-topology.c
+++ b/sound/soc/soc-topology.c
@@ -1475,6 +1475,7 @@ widget:
 	if (widget == NULL) {
 		dev_err(tplg->dev, "ASoC: failed to create widget %s controls\n",
 			w->name);
+		ret = -ENOMEM;
 		goto hdr_err;
 	}
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help