[PATCH 3.16 101/114] net: fix infoleak in llc
From: Ben Hutchings <hidden>
Date: 2016-06-13 18:54:52
Also in:
lkml
From: Ben Hutchings <hidden>
Date: 2016-06-13 18:54:52
Also in:
lkml
3.16.36-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Kangjie Lu <redacted> commit b8670c09f37bdf2847cc44f36511a53afc6161fd upstream. The stack object “info” has a total size of 12 bytes. Its last byte is padding which is not initialized and leaked via “put_cmsg”. Signed-off-by: Kangjie Lu <redacted> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <redacted> --- net/llc/af_llc.c | 1 + 1 file changed, 1 insertion(+)
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c@@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr * if (llc->cmsg_flags & LLC_CMSG_PKTINFO) { struct llc_pktinfo info; + memset(&info, 0, sizeof(info)); info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex; llc_pdu_decode_dsap(skb, &info.lpi_sap); llc_pdu_decode_da(skb, info.lpi_mac);